Fixed issues running INGRID on python>=3.10 #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@wearysebas @timothy-nunn does this fix the same issue as in your PR #29? I can see lots of additional commits there related to CDN and MASTU configurations there, so is the scope of that much broader than this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates to two INGRID dependencies (freeqdsk and matplotlib) were causing it to fail on a fresh conda environment with python>=3.10. This update fixes this, and should also fix failing CI runs.
How was this tested?
On my local machine I created fresh conda environments using python 3.9, 3.10, 3.11 and 3.12 and successfully ran INGRID on all of them, including tests.
Relevant issues
Closes #34 and #30
Checklist
I have added/updated tests relevant to this PR.I have updated any baselines required for the test suite.